Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,6 @@ cmake .. -G "Unix Makefiles" -DCMAKE_TOOLCHAIN_FILE=$GENERATORS_DIR/conan_toolch
-DPRIVMX_BUILD_DEBUG_APPS=OFF \
-DPRIVMX_BUILD_ENDPOINT_INTERFACE=ON \
-DPRIVMX_ENABLE_TESTS=ON \
-DPRIVMX_ENABLE_TESTS_E2E=ON \
-DPRIVMX_ENABLE_TESTS_E2E=ON
cmake --build . -- -j20
source $GENERATORS_DIR/deactivate_conanbuild.sh
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,6 @@ class StreamApiLowImpl : public privmx::utils::ManualManagedClass<StreamApiLowIm
);

void trickle(const int64_t sessionId, const std::string& candidateAsJson);
void acceptOfferOnReconfigure(const int64_t sessionId, const SdpWithTypeModel& sdp);
void setNewOfferOnReconfigure(const int64_t sessionId, const SdpWithTypeModel& sdp);

core::Buffer encryptDataChannelMessage(const std::string& streamRoomId, const DataChannelMessage& plainMessage);
Expand Down Expand Up @@ -182,6 +181,7 @@ class StreamApiLowImpl : public privmx::utils::ManualManagedClass<StreamApiLowIm
virtual std::pair<core::ModuleKeys, int64_t> getModuleKeysAndVersionFromServer(std::string moduleId) override;
core::ModuleKeys streamRoomToModuleKeys(server::StreamRoomInfo streamRoom);
void assertTurnServerUri(const std::string& uri);
void acceptOfferOnReconfigure(const int64_t sessionId, const SdpWithTypeModel& sdp);

static int32_t nextIdCounter;
static int32_t nextId() { return nextIdCounter++; }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,13 +51,12 @@ class StreamApiLowVarInterface {
UpdateSubscriberStream = 17,
RemoveSubscriberStream = 18,
Trickle = 19,
AcceptOfferOnReconfigure = 20,
KeyManagement = 21,
UpdateStream = 22,
JoinStreamRoomEx = 23,
ListStreamRoomParticipants = 24,
EncryptDataChannelMessage = 25,
DecryptDataChannelMessage = 26,
KeyManagement = 20,
UpdateStream = 21,
JoinStreamRoomEx = 22,
ListStreamRoomParticipants = 23,
EncryptDataChannelMessage = 24,
DecryptDataChannelMessage = 25,
};

StreamApiLowVarInterface(core::Connection connection, const core::VarSerializer& serializer)
Expand Down Expand Up @@ -91,7 +90,6 @@ class StreamApiLowVarInterface {
Poco::Dynamic::Var listStreamRoomParticipants(const Poco::Dynamic::Var& args);

Poco::Dynamic::Var trickle(const Poco::Dynamic::Var& args);
Poco::Dynamic::Var acceptOfferOnReconfigure(const Poco::Dynamic::Var& args);
Poco::Dynamic::Var setNewOfferOnReconfigure(const Poco::Dynamic::Var& args);

Poco::Dynamic::Var encryptDataChannelMessage(const Poco::Dynamic::Var& args);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,6 @@ class StreamApiLow : public privmx::endpoint::core::ExtendedPointer<StreamApiLow
);

void trickle(const int64_t sessionId, const std::string& candidateAsJson);
void acceptOfferOnReconfigure(const int64_t sessionId, const SdpWithTypeModel& sdp);
void setNewOfferOnReconfigure(const int64_t sessionId, const SdpWithTypeModel& sdp);

void joinStreamRoom(
Expand Down
11 changes: 0 additions & 11 deletions endpoint/stream/stream/src/StreamApiLow.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -307,17 +307,6 @@ void StreamApiLow::trickle(const int64_t sessionId, const std::string& candidate
}
}

void StreamApiLow::acceptOfferOnReconfigure(const int64_t sessionId, const SdpWithTypeModel& sdp) {
auto impl = getImpl();
core::Validator::validateNumberPositive(sessionId, "field:sessionId ");
try {
return impl->acceptOfferOnReconfigure(sessionId, sdp);
} catch (const privmx::utils::PrivmxException& e) {
core::ExceptionConverter::rethrowAsCoreException(e);
throw core::Exception("ExceptionConverter rethrow error");
}
}

void StreamApiLow::setNewOfferOnReconfigure(const int64_t sessionId, const SdpWithTypeModel& sdp) {
auto impl = getImpl();
core::Validator::validateNumberPositive(sessionId, "field:sessionId ");
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -232,14 +232,6 @@ Poco::Dynamic::Var StreamApiLowVarInterface::trickle(const Poco::Dynamic::Var& a
return {};
}

Poco::Dynamic::Var StreamApiLowVarInterface::acceptOfferOnReconfigure(const Poco::Dynamic::Var& args) {
auto argsArr = core::VarInterfaceUtil::validateAndExtractArray(args, 2);
auto sessionId = _deserializer.deserialize<int64_t>(argsArr->get(0), "sessionId");
auto jsep = _deserializer.deserialize<stream::SdpWithTypeModel>(argsArr->get(1), "jsep");
_streamApi.acceptOfferOnReconfigure(sessionId, jsep);
return {};
}

Poco::Dynamic::Var StreamApiLowVarInterface::setNewOfferOnReconfigure(const Poco::Dynamic::Var& args) {
auto argsArr = core::VarInterfaceUtil::validateAndExtractArray(args, 2);
auto sessionId = _deserializer.deserialize<int64_t>(argsArr->get(0), "sessionId");
Expand Down
2 changes: 1 addition & 1 deletion test/test_env/utils/empty_server_and_mongo.yml
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ services:
start_interval: 1s

teamserver:
image: privmx-bridge
image: ${DOCKER_BRIDGE_IMAGE}:${DOCKER_BRIDGE_VERSION}
env_file:
- path: ./bridge.env
required: false
Expand Down
Loading