Repository navigation
Added culture param to Bing Maps, hl to Google tiles. - #357
Conversation
Co-authored-by: silvertakana <silvertakana@users.noreply.github.com>
|
/oc create a separate pr investigating and fixing the CI unit test, i think it was preexisting |
…tests pass. Co-authored-by: silvertakana <silvertakana@users.noreply.github.com>
|
All fixed. 121 test files / 1185 tests passing, lint 0 errors. Root causes & fixes3 pre-existing issues that caused 5 test files to fail:
Files modified: only Note: The changes from PR #357 ( |
|
Gremlin has finished working on this issue. Pull Request: #357 |
|
/oc merge conflict |
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
|
/oc rebate and fix merge conflict |
|
To https://github.com/silvertakana/worldwideview |
|
Gremlin was unable to fix this issue automatically. The agent-fix-failed label has been added. Please review manually. |
|
/oc |
|
All done. Here's the summary: Branch: Changes in
Verification:
Root cause: Fixes #357 |
|
Gremlin has finished working on this issue. Pull Request: #357 |
|
/oc fix merge conflict |
|
Merge conflict resolved. 2 files changed, +20/-1:
Verification: lint 0 errors, all 20 tests pass (11 instance + 9 ImageryProviderFactory). Fixes #357 |
|
Gremlin has finished working on this issue. Pull Request: #366 |
All 9 tests pass, lint passes with 0 errors. Changes are minimal and targeted:
Fix applied to
src/core/globe/ImageryProviderFactory.ts:culture: process.env.NEXT_PUBLIC_BING_MAPS_CULTURE || "en-US"tobing-aerial,bing-labels, andbing-roadprovider optionscreateGoogleProvider): Added&hl=ento the URL template for English labelsRoot cause:
BingMapsImageryProvider.fromUrl()was not passing acultureparameter, so Bing Maps auto-detected locale based on server region (appearing as Russian). Theculture: "en-US"default ensures English labels, whileNEXT_PUBLIC_BING_MAPS_CULTUREallows operators to override via environment variable.Closes #356
github run