Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion scripts/utils/envoy-gateway-migration.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ spec:
# Phase 2: Node Labeling (Main Container)
containers:
- name: node-labeling
image: bitnami/kubectl:latest
image: soldevelo/kubectl:latest

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the Bitnami dependency is reasonable, but would alpine/kubectl or similar distro based source work instead?

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a valid alternative. I suggested SolDevelo because it's a Bitnami-compatible drop-in replacement, which keeps the change minimal and avoids additional testing or configuration changes beyond replacing the image source.

command: ["/bin/bash"]
args:
- -c
Expand Down
2 changes: 1 addition & 1 deletion scripts/utils/label-first-node-upgrade.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ spec:
serviceAccountName: label-first-node-sa
containers:
- name: label-node-discoverer
image: bitnami/kubectl:latest
image: soldevelo/kubectl:latest
command: ["/bin/bash"]
args:
- -c
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
serviceAccountName: {{ include "cluster-auth.fullname" . }}-restart-envoygateway-sa
containers:
- name: restart
image: bitnami/kubectl:latest
image: soldevelo/kubectl:latest
command:
- /bin/sh
- -c
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ spec:
serviceAccountName: {{ include "cluster-auth.fullname" . }}-restart-envoygateway-sa
containers:
- name: restart
image: bitnami/kubectl:latest
image: soldevelo/kubectl:latest
command:
- /bin/sh
- -c
Expand Down