Migrate to a mono-repo structure powered by turbo#57
Open
Pearce-Ropion wants to merge 14 commits into
Open
Conversation
Pearce-Ropion
commented
May 11, 2026
| pluginConfig[key] = JSON.parse(value); | ||
| } catch (_err: unknown) { | ||
| if (__VITEST_BROWSER__ && (key === 'frameId' || key === 'sessionId')) { | ||
| if (__VITEST_BROWSER__ && (key === 'iframeId' || key === 'sessionId')) { |
Collaborator
Author
There was a problem hiding this comment.
This was an error from my previous PR in #49
Pearce-Ropion
commented
May 11, 2026
Collaborator
Author
There was a problem hiding this comment.
Currently the this file and the root's readme file are duplicates. I will clean this up later once I've added added the react package
Pearce-Ropion
commented
May 11, 2026
|
|
||
| dts: true, | ||
| dts: { | ||
| build: true, |
Collaborator
Author
There was a problem hiding this comment.
Switch to build mode because the tsconfig uses references now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the existing package into a subpackage called
@sigamcomputing/plugin-sdk(does not include npm package rename - will do this separately)Turbo-ifies all base commands
Separates root dependencies from package dependencies
Add Syncpack to control package versions
Adds a new tsconfig structure to only allow valid types in a given file
Re: Renaming
Goal: I would like to rename the existing package from
@sigmacomputing/pluginto@sigmacomputing/plugin-sdkto match our existing@sigmacomputing/embed-sdksyntax.@sigmacomputing/pluginat the same time to "deprecate" it@sigmacomputing/plugin-sdk-react