Skip to content

Replace Cursor-based streaming with getAll method - #1650

Open
hkben wants to merge 1 commit into
sienori:masterfrom
hkben:dataloading
Open

hkben wants to merge 1 commit into
sienori:masterfrom
hkben:dataloading

Conversation

@hkben

@hkben hkben commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

This is one of two parts of an optimization aimed at improving popup‑opening speed. This part focuses on data loading.

This pull request refactors the getAllWithStream method, changing it from cursor‑based streaming to getAll with pagination. Cursor‑based streaming creates a callback for every row, which is much slower than getAll, which returns multiple rows in a single callback. The change helps improve the speed of loading session data when opening the popup.

superuser-miguel added a commit to superuser-miguel/Tab-Session-Garrison that referenced this pull request Sep 23, 2026
One IndexedDB request per batch of 30 instead of one cursor round-trip per
record (after upstream PR sienori#1650). Pages on the raw record's key, so it no
longer depends on callers requesting "id", and a missing count can't loop.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant