Skip to content

refactor: several code quality improvements - #49

Merged
zeschg merged 6 commits into
masterfrom
tz/refactor_code_quality
Jul 24, 2026
Merged

zeschg merged 6 commits into
masterfrom
tz/refactor_code_quality

Conversation

@zeschg

@zeschg zeschg commented Jul 23, 2026 •

Copy link
Copy Markdown
Collaborator

This PR tires to fix the following SonarQube issue types:

  • Unused function parameters should be removed c:S1172
  • Implicit casts should not lower precision c:S5276
  • Pointer and reference local variables should be "const" if the corresponding object is not modified c:S5350
  • "switch" statements should cover all cases c:S3562
  • Loop variables should be declared in the minimal possible scope c:S5955
  • Unnecessary parentheses should be removed c:S1110

@zeschg zeschg self-assigned this Jul 23, 2026
@zeschg
zeschg force-pushed the tz/refactor_code_quality branch from 19a71c6 to d7abe15 Compare July 24, 2026 10:27
@zeschg zeschg changed the title refactor: seceral code quality improvements refactor: several code quality improvements Jul 24, 2026
@zeschg
zeschg force-pushed the tz/refactor_code_quality branch from d7abe15 to c544855 Compare July 24, 2026 12:37
@github-advanced-security

Copy link
Copy Markdown

You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool.

What Enabling Code Scanning Means:

  • The 'Security' tab will display more code scanning analysis results (e.g., for the default branch).
  • Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results.
  • You will be able to see the analysis results for the pull request's branch on this overview once the scans have completed and the checks have passed.

For more information about GitHub Code Scanning, check out the documentation.

Comment thread src/lib/uta_sim.c Fixed
@zeschg
zeschg force-pushed the tz/refactor_code_quality branch from c544855 to 2edede2 Compare July 24, 2026 12:47
@zeschg
zeschg force-pushed the tz/refactor_code_quality branch from 2edede2 to 1ff47a2 Compare July 24, 2026 13:23
@sonarqubecloud

sonarqubecloud Bot commented Jul 24, 2026 •

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
0 New issues
2 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@zeschg
zeschg marked this pull request as ready for review July 24, 2026 13:33
@zeschg
zeschg requested a review from hseuschek July 24, 2026 13:33
@zeschg
zeschg merged commit 4f3f47e into master Jul 24, 2026
11 checks passed
@zeschg
zeschg deleted the tz/refactor_code_quality branch July 24, 2026 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants