Default LookML view table to the view name when unspecified

sidemantic/adapters/lookml.py

@@ -583,6 +583,23 @@ def _parse_view(self, view_def: dict) -> Model | None:
             elif isinstance(extends_list, str):
                 extends = extends_list
 
+        # A LookML view with no sql_table_name and no derived_table implicitly
+        # uses a table named after the view (Looker's default). Apply that so the
+        # model is valid instead of failing validation with "must have a table".
+        # Skip refinements (merged into their base), views that inherit a table
+        # via extends or are abstract (extension: required), and fieldless
+        # placeholder views (which have nothing to query anyway).
+        if (
+            table is None
+            and sql is None
+            and not view_def.get("derived_table")
+            and not extends
+            and not name.startswith("+")
+            and view_def.get("extension") != "required"
+            and (dimensions or measures)
+        ):
+            table = name
+
         # Build kwargs conditionally so that unset scalars don't appear in
         # model_fields_set. This matters for refinements: merge_model treats
         # every field in model_fields_set as an explicit child override, so

tests/adapters/lookml/test_edge_cases.py

@@ -2198,6 +2198,37 @@ def test_lookml_self_referential_dimension_terminates():
     assert selfd.sql.count("+ 1") <= 2
 
 
+def test_lookml_view_with_unsupported_derived_table_not_defaulted():
+    """A view with a derived_table the adapter can't read must NOT get a default physical table."""
+    adapter = LookMLAdapter()
+    model = adapter._parse_view(
+        {
+            "name": "ndt_unknown",
+            # derived_table with no sql / explore_source the adapter understands
+            "derived_table": {"persist_for": "1 hour"},
+            "dimensions": [{"name": "id", "type": "number", "sql": "${TABLE}.id"}],
+        }
+    )
+    assert model.table is None  # not fabricated as a physical table named after the view
+
+
+def test_lookml_view_without_table_defaults_to_view_name():
+    """A view with no sql_table_name/derived_table should default its table to the view name."""
+    from sidemantic import SemanticLayer
+
+    graph = _parse_lkml(
+        "view: just_fields { "
+        "dimension: id { primary_key: yes  type: number  sql: ${TABLE}.id ;; } "
+        "measure: c { type: count } }"
+    )
+    model = graph.get_model("just_fields")
+    assert model.table == "just_fields"
+    # And it must be a valid, queryable model (previously raised ModelValidationError).
+    layer = SemanticLayer()
+    layer.add_model(model)
+    assert "just_fields" in layer.compile(metrics=["just_fields.c"])
+
+
 def test_lookml_export_unmapped_aggregations_not_count():
     """Unmapped aggregations / complex types must not be silently exported as COUNT."""
     import tempfile

tests/adapters/test_added_fixture_coverage.py

@@ -227,7 +227,8 @@
     "tests/fixtures/lookml/ga360_ga_block.view.lkml",
     "tests/fixtures/lookml/lkml_model_all_fields.model.lkml",
     "tests/fixtures/lookml/lkml_parameter_join.model.lkml",
-    "tests/fixtures/lookml/node_lookml_refinement_merging.model.lkml",
+    # node_lookml_refinement_merging now compiles: its `deep_merging` view has a
+    # dimension and (per Looker semantics) defaults its table to the view name.
     "tests/fixtures/lookml/node_lookml_refinement_sequencing.model.lkml",
     "tests/fixtures/lookml/pylookml_aggregate_tables.model.lkml",
     "tests/fixtures/lookml/pylookml_manifest.lkml",