Repository navigation
Make the star card's UI test survive a lost tap and leave relaunch persistence to the unit test - #178
Merged
Conversation
whoisaldo
marked this pull request as ready for review
November 3, 2026 19:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ConnectScreenTests.testTheStarCardFollowsALongSessionAndClosesis new in 0.3.4 and failed twice on busy CI runners, at two different steps.:63"closed for good":starCardClosedsetting hadn't been saved before the kill.:58:The test now:
That a closed card stays closed across launches is already a unit test:
FeedbackTests.testATapThanksAndACloseRetiresTheStarCard(FeedbackTests.swift:190-211) builds a freshStarAskfrom the same store. The update-banner rule is also a unit test there. The app is unchanged.Tested: the earlier head's version of this test passed 10 of 10 on an iOS 18.6 iPad Pro 13" simulator, and
ConnectScreenTestspassed 11 of 11. This head's CI runs the changed test.Release notes: none