Skip to content

Make the star card's UI test survive a lost tap and leave relaunch persistence to the unit test - #178

Merged
whoisaldo merged 2 commits into
release/0.3.4-candidatefrom
test/star-card-close-persists
Nov 3, 2026
Merged

whoisaldo merged 2 commits into
release/0.3.4-candidatefrom
test/star-card-close-persists

Conversation

@whoisaldo

@whoisaldo whoisaldo commented Nov 3, 2026 •

Copy link
Copy Markdown
Member

ConnectScreenTests.testTheStarCardFollowsALongSessionAndCloses is new in 0.3.4 and failed twice on busy CI runners, at two different steps.

  1. The release head b7b4d25 (run 41689814100, iOS job), :63 "closed for good":
    • The card disappeared after Close at t=22.91 s, and XCTest terminated the app at t=23.04 s.
    • On relaunch the card was back: the starCardClosed setting hadn't been saved before the kill.
  2. This PR's first head, bbe684c (run 41695596742), :58:

The test now:

  • taps Close and, if the card is still there after 5 s, taps once more, then asserts the card is gone;
  • no longer relaunches the app right after Close.

That a closed card stays closed across launches is already a unit test: FeedbackTests.testATapThanksAndACloseRetiresTheStarCard (FeedbackTests.swift:190-211) builds a fresh StarAsk from the same store. The update-banner rule is also a unit test there. The app is unchanged.

Tested: the earlier head's version of this test passed 10 of 10 on an iOS 18.6 iPad Pro 13" simulator, and ConnectScreenTests passed 11 of 11. This head's CI runs the changed test.

Release notes: none

@whoisaldo whoisaldo added the 0.3.4 Part of the 0.3.4 release label Nov 3, 2026
@whoisaldo
whoisaldo requested a review from Alitleis123 November 3, 2026 18:37
@whoisaldo whoisaldo changed the title Save the star card's closed state before its test relaunches the app Make the star card's UI test survive a lost tap and leave relaunch persistence to the unit test Nov 3, 2026
@whoisaldo
whoisaldo marked this pull request as ready for review November 3, 2026 19:30
@whoisaldo
whoisaldo merged commit ac8ea92 into release/0.3.4-candidate Nov 3, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

0.3.4 Part of the 0.3.4 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants