Instead of using $parent and an isolate scope, use $parse. - #7
Open
mrajcok wants to merge 1 commit into
Open
Conversation
specify which scope function the directive should call when a date is selected via the jQuery plugin UI. There have been some discussions on StackOverflow about using ngModel and isolate scopes. The general concensus seems to be "don't": http://stackoverflow.com/questions/11896732/ngmodel-and-component-with-isolated-scope http://stackoverflow.com/questions/15419629/angularjs-two-way-data-binding-fails-if-element-has-ngmodel-and-a-custom-direct/15419873#15419873 "Since you are trying to create a component that must interact with other directives, an isolate scope is not the best choice."
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of using $parent and an isolate scope, $parse can be used to specify which scope function the directive should call when a date is selected via the jQuery plugin UI.
There have been some discussions on StackOverflow about using ngModel
and isolate scopes. The general concensus seems to be "don't":
http://stackoverflow.com/questions/11896732/ngmodel-and-component-with-isolated-scope
http://stackoverflow.com/questions/15419629/angularjs-two-way-data-binding-fails-if-element-has-ngmodel-and-a-custom-direct/15419873#15419873
"Since you are trying to create a component that must interact with other
directives, an isolate scope is not the best choice."