Skip to content

[feat] add DoubleQuoteUsage to PhpCsFixer Rule - #361

Merged
khanzadimahdi merged 4 commits into
shetabit:masterfrom
alissn:UpdateRule
Aug 31, 2026
Merged

[feat] add DoubleQuoteUsage to PhpCsFixer Rule#361
khanzadimahdi merged 4 commits into
shetabit:masterfrom
alissn:UpdateRule

Conversation

@alissn

@alissn alissn commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Hi,

This PR adds the Squiz.Strings.DoubleQuoteUsage rule to PHP_CodeSniffer to enforce single quotes when double quotes are not necessary.

--- Original
+++ New
 <?php

-$a = "sample";
+$a = 'sample';
 $b = "sample with 'single-quotes'";

@alissn
alissn marked this pull request as draft August 30, 2026 23:18
@codecov-commenter

codecov-commenter commented Aug 30, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 85.95506% with 50 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (master@c031a54). Learn more about missing BASE report.

Files with missing lines Patch % Lines
src/Drivers/Atipay/Core/fn.atipay.php 14.28% 18 Missing ⚠️
src/Drivers/Aqayepardakht/Aqayepardakht.php 42.30% 15 Missing ⚠️
src/Drivers/Behpardakht/Behpardakht.php 0.00% 7 Missing ⚠️
src/Drivers/Zarinpal/Strategies/Sandbox.php 60.00% 6 Missing ⚠️
src/Drivers/Saman/Saman.php 0.00% 2 Missing ⚠️
src/Drivers/Omidpay/Omidpay.php 85.71% 1 Missing ⚠️
src/Drivers/Paypal/Paypal.php 93.75% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff            @@
##             master     #361   +/-   ##
=========================================
  Coverage          ?   79.59%           
  Complexity        ?     1039           
=========================================
  Files             ?       65           
  Lines             ?     5493           
  Branches          ?        0           
=========================================
  Hits              ?     4372           
  Misses            ?     1121           
  Partials          ?        0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@khanzadimahdi

Copy link
Copy Markdown
Member

could you please fix the pipeline? it is failing at the moment!

@alissn
alissn marked this pull request as ready for review August 31, 2026 13:00
@alissn

alissn commented Aug 31, 2026

Copy link
Copy Markdown
Contributor Author

@khanzadimahdi

I was holding this pull request until PR #349 was merged because it contained several changes, to prevent conflicts.

PR #349 has now been merged, so this pull request can be merged as well.

@khanzadimahdi
khanzadimahdi merged commit e601a55 into shetabit:master Aug 31, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants