Fix panic on --runs 0 - #923
Open
VXNCXNX wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's broken
--runs 0and--max-runs 0panic with an arithmetic overflow instead of reporting the bad value.--min-runs 0panics too, for any command slower than the minimum benchmarking time.Repro
Exit code is 101. It is easy to hit from a script where the run count comes from a variable.
The fix
Benchmark::runcomputescount - 1after the initial timing run, so a count of zero underflows. An explicit maximum of zero is rejected inOptions::from_cli_arguments, since asking for at most zero runs cannot be satisfied. A zero minimum is treated as valid and clamped to 1 instead of rejected: no lower bound is a coherent request, and the initial run has already happened by then. Happy to reject--min-runs 0as well if you would rather have it symmetric.Verification
Two tests added in
tests/integration_tests.rs. Full suite passes (44 / 19 / 41),cargo fmt --checkclean.Disclosure: this patch was written with the help of Claude (an LLM). I reviewed the diff, ran the test suite, and verified the behaviour against a real build before opening this.