Improve preview and partial upload of changed Gist files - #1474
Open
landeqiming666 wants to merge 1 commit into
Open
Improve preview and partial upload of changed Gist files#1474landeqiming666 wants to merge 1 commit into
landeqiming666 wants to merge 1 commit into
Conversation
Author
|
Hi, a brief follow-up on this PR. It remains mergeable and keeps the change scoped to previewing changed Gist files and uploading only the selected changes. No code-check failure is currently shown. Happy to add coverage or narrow the UI flow further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
keybindings*filesThis covers the preview/confirmation path in addition to the minimal-patch and deletion semantics already explored in the other proposals for #508.
Validation
npm run tslint-checkTS_NODE_TRANSPILE_ONLY=1 node -r ts-node/register ./node_modules/mocha/bin/mocha test/service/gistChange/gistChange.test.ts --reporter spec(4 passing)git diff --checkThe repository has no lockfile. On a current Node installation, its full TypeScript compilation resolves incompatible transitive type packages and fails inside existing
@octokit/restdeclarations before checking this change. The focused behavioral tests and lint pass without modifying project dependencies.IssueHunt Summary
Referenced issues
This pull request has been submitted to: