Skip to content

Improve preview and partial upload of changed Gist files - #1474

Open
landeqiming666 wants to merge 1 commit into
shanalikhan:masterfrom
landeqiming666:improve-gist-upload-preview
Open

Improve preview and partial upload of changed Gist files#1474
landeqiming666 wants to merge 1 commit into
shanalikhan:masterfrom
landeqiming666:improve-gist-upload-preview

Conversation

@landeqiming666

@landeqiming666 landeqiming666 commented Jul 12, 2026

Copy link
Copy Markdown

Summary

  • build one change plan from the local and remote Gist file sets
  • show the exact created, changed, and deleted files before a normal upload
  • send a minimal Gist PATCH, including explicit deletions while preserving cross-platform keybindings* files
  • retain the existing full-payload behavior for forced uploads

This covers the preview/confirmation path in addition to the minimal-patch and deletion semantics already explored in the other proposals for #508.

Validation

  • npm run tslint-check
  • TS_NODE_TRANSPILE_ONLY=1 node -r ts-node/register ./node_modules/mocha/bin/mocha test/service/gistChange/gistChange.test.ts --reporter spec (4 passing)
  • git diff --check

The repository has no lockfile. On a current Node installation, its full TypeScript compilation resolves incompatible transitive type packages and fails inside existing @octokit/rest declarations before checking this change. The focused behavioral tests and lint pass without modifying project dependencies.


IssueHunt Summary

Referenced issues

This pull request has been submitted to:


@landeqiming666

Copy link
Copy Markdown
Author

Hi, a brief follow-up on this PR. It remains mergeable and keeps the change scoped to previewing changed Gist files and uploading only the selected changes. No code-check failure is currently shown. Happy to add coverage or narrow the UI flow further.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant