Preserve installed disabled extensions in synced extension list - #1471
Open
bpc-oss wants to merge 1 commit into
Open
Preserve installed disabled extensions in synced extension list#1471bpc-oss wants to merge 1 commit into
bpc-oss wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change fixes the case from #143 where disabled extensions can disappear from sync because they are installed on disk but missing from the VS Code API extension list.
What changed
publisherIdwhen extension metadata is missingScope
This is a conservative fix.
It preserves installed disabled extensions during export/sync list creation, but does not attempt to implement full disabled-state synchronization semantics.
Verification
Targeted checks completed locally:
npm run tslint-check