Skip to content

Tests: Assert matched route for edit site export OPTIONS checks. - #1

Closed
shail-mehta wants to merge 1 commit into
tests/66073-edit-site-export-negative-assertionsfrom
tests/66073-edit-site-export-options-matched-route
Closed

shail-mehta wants to merge 1 commit into
tests/66073-edit-site-export-negative-assertionsfrom
tests/66073-edit-site-export-options-matched-route

Conversation

@shail-mehta

Copy link
Copy Markdown
Owner

Part of: #66073

Follow-up to: WordPress#14115

What

Strengthens the OPTIONS probes in Tests_REST_WpRestEditSiteExportController::test_update_item() and test_delete_item() by also asserting the matched route.

Updated file: tests/phpunit/tests/rest-api/wpRestEditSiteExportController.php

Why

rest_handle_options_request() can return a default 200 even when no route matches, so status alone does not prove the export route exists. Asserting $response->get_matched_route() makes that check reliable. The existing route-registration test already covers registration; this is a small strengthening of the update/delete negatives.

How

  • Keep the OPTIONS request used to prove the route (GET would trigger the ZIP export and exit)
  • After assertSame( 200, $response->get_status() ), add assertSame( $route, $response->get_matched_route() ) in both test_update_item() and test_delete_item()

Testing instructions

  1. Start the local WordPress develop environment.
  2. Run: npm run test:php -- --filter Tests_REST_WpRestEditSiteExportController

Use of AI tools

Cursor

Strengthen the OPTIONS probes in update/delete negatives so a default 200 without a real route match would fail.

Follow-up to WordPress#14115.
See #66073.
@shail-mehta shail-mehta self-assigned this Oct 10, 2026
@shail-mehta
shail-mehta marked this pull request as ready for review October 10, 2026 12:53
@github-actions

Copy link
Copy Markdown

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props shailu25.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta
shail-mehta deleted the tests/66073-edit-site-export-options-matched-route branch October 10, 2026 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant