Skip to content

fix(android): stop inline sheet content from appearing twice in the view tree - #7

Merged
sergeymild merged 1 commit into
mainfrom
fix/inline-view-tree-duplicate
Oct 6, 2026
Merged

sergeymild merged 1 commit into
mainfrom
fix/inline-view-tree-duplicate

Conversation

@sergeymild

Copy link
Copy Markdown
Owner

On Android an inline sheet's content is attached under the screen stack, but the sheet view still reported it through getChildCount/getChildAt, so tree walkers (Espresso/Detox, accessibility) reached every view twice — Detox failed with "matches 2 views".

  • AppFittedSheet: in inline mode the View no longer lists the relocated children; the React-side child list moves to reactChildCount/reactChildAt.
  • Sheet2ViewManager: Fabric gets children through the manager's getChildCount/getChildAt; the nested ScrollView lookup starts from mHostView.
  • Version 7.12.1.

@sergeymild
sergeymild merged commit 2343f83 into main Oct 6, 2026
0 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant