Repository navigation
Read escaped surrogate pairs in JSON strings - #412
Merged
agocke merged 3 commits intoOct 4, 2026
Merged
Conversation
Co-authored-by: agocke <515774+agocke@users.noreply.github.com>
Co-authored-by: agocke <515774+agocke@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix JSON deserializer for escaped surrogate pairs
Read escaped surrogate pairs in JSON strings
Oct 4, 2026
agocke
marked this pull request as ready for review
October 4, 2026 16:43
agocke
deleted the
copilot/fix-json-deserializer-escaped-surrogate-pairs
branch
October 4, 2026 16:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Serde can deserialize unescaped emoji but rejects their
\u-escaped surrogate-pair form, including output from its own JSON serializer.JsonValue.For example,
{"text":"\uD83E\uDD16"}should deserialize withtextset to🤖.