Skip to content

Remove accidental duplicated streamlines on diagonal - #1368

Merged
arnaudbore merged 1 commit into
scilus:masterfrom
frheault:remove_duplication_self_connections
Oct 27, 2026
Merged

arnaudbore merged 1 commit into
scilus:masterfrom
frheault:remove_duplication_self_connections

Conversation

@frheault

Copy link
Copy Markdown
Member

Quick description

Please include a summary of the changes and the related issue(s) or improvement(s).
Please also include relevant motivation and context. List any dependencies that are required for this change if needed.

...

Type of change

Check the relevant options.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Provide data, screenshots, command line to test (if relevant)

...

Checklist

  • My code follows the style guidelines of this project (run autopep8)
  • I added relevant citations to scripts, modules and functions docstrings and descriptions
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I moved all functions from the script file (except the argparser and main) to scilpy modules
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@arnaudbore arnaudbore left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GTG

@codecov

codecov Bot commented Oct 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 72.57%. Comparing base (7146797) to head (d486a5f).
⚠️ Report is 161 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1368      +/-   ##
==========================================
- Coverage   72.65%   72.57%   -0.09%     
==========================================
  Files         295      301       +6     
  Lines       25603    26279     +676     
  Branches     3607     3702      +95     
==========================================
+ Hits        18602    19071     +469     
- Misses       5487     5655     +168     
- Partials     1514     1553      +39     
Flag Coverage Δ
smoketests 69.73% <100.00%> (-0.08%) ⬇️
unittests 14.22% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Scripts 75.26% <ø> (+0.07%) ⬆️
Library 69.33% <100.00%> (-0.31%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@arnaudbore
arnaudbore added this pull request to the merge queue Oct 27, 2026
Merged via the queue into scilus:master with commit c787973 Oct 27, 2026
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants