Add weighted Delaunay triangulation

[kiranvad]

Hey,
I added a function to compute a weighted Delaunay triangulation (to Alpha filtration) which is a really useful tool for people working with molecules and alpha complexes.
The basic idea is to compute Delaunay triangulation using its duality with convex hull of one dimension above.
I am not sure if usage of a weighted Dealunay would require a change in the circumradius computation(think not). I also added a three line example in the BasicUsage.ipynb.

Have a look and let me know what you think.

[codecov]

Codecov Report

❌ Patch coverage is 33.33333% with 14 lines in your changes missing coverage. Please review.
✅ Project coverage is 89.72%. Comparing base (93d0220) to head (f7d518c).
⚠️ Report is 30 commits behind head on master.

Files with missing lines	Patch %	Lines
cechmate/filtrations/alpha.py	33.33%	14 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master      #15      +/-   ##
==========================================
- Coverage   92.91%   89.72%   -3.19%     
==========================================
  Files          12       12              
  Lines         381      399      +18     
==========================================
+ Hits          354      358       +4     
- Misses         27       41      +14     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[ctralie]

Hi Kiran, Thank you so much for this pull request. This sounds correct, and I'm quite sure that qhull itself computes the Delaunay triangulation this way, but I would like a moment to add some unit tests and be sure (it's strange that qhull doesn't support this natively). I will try to knock this out at the same time that I investigate your bug, within the next week. Thank you again for your patience. Sincerely, Chris

…

On Sat, Jan 25, 2020 at 5:06 PM Kiran Vaddi ***@***.***> wrote: Hey, I added a function to compute a weighted Delaunay triangulation (to Alpha filtration) which is a really useful tool for people working with molecules and alpha complexes. The basic idea is to compute Delaunay triangulation using its duality with convex hull of one dimension above. I am not sure if usage of a weighted Dealunay would require a change in the circumradius computation(think not). I also added a three line example in the BasicUsage.ipynb. Have a look and let me know what you think. ------------------------------ You can view, comment on, or merge this pull request online at: #15 Commit Summary - add weighted delaunay triangulation File Changes - *M* cechmate/filtrations/alpha.py <https://github.com/scikit-tda/cechmate/pull/15/files#diff-0> (64) - *M* docs/notebooks/BasicUsage.ipynb <https://github.com/scikit-tda/cechmate/pull/15/files#diff-1> (23) Patch Links: - https://github.com/scikit-tda/cechmate/pull/15.patch - https://github.com/scikit-tda/cechmate/pull/15.diff — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#15?email_source=notifications&email_token=AAJWDZVTX5W4NPUQIMGFKKDQ7SZXNA5CNFSM4KLTJEKKYY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4IIW24KA>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJWDZVU2JOH4GBDCOKGF2LQ7SZXNANCNFSM4KLTJEKA> .

[sauln]

@ctralie What is the status of this? do we still have work to do moving this PR forward?

[ctralie]

Yeah, Umberto Lupo and I are doing a major overhaul of this library, and this will be something we include on the side. Pandemic teaching has slowed me down, but we're doing our best

…

On Mon, Mar 1, 2021 at 8:24 PM Nathaniel Saul ***@***.***> wrote: @ctralie <https://github.com/ctralie> What is the status of this? do we still have work to do moving this PR forward? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#15 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJWDZSC7FEO4REJFFP23DTTBQ46LANCNFSM4KLTJEKA> .