x1559: Allow several sections to be put into one slot in sectioning - #675
Open
khelwood wants to merge 1 commit into
Open
x1559: Allow several sections to be put into one slot in sectioning#675khelwood wants to merge 1 commit into
khelwood wants to merge 1 commit into
Conversation
So now we can have several planactions targeting the same slot and several confirmactions as well. Instead, we dedupe actions based on a combination of destination slot and sample data. It's hard to keep mental track of, but the integration test seems to confirm it works.
sabrine33
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So now we can have several planactions targeting the same slot and several confirmactions as well. Instead, we dedupe actions based on a combination of destination slot and sample data. It's hard to keep mental track of, but the integration test seems to confirm it works.
For #672