feat: adds Iso-Seq_cDNA_amp_primer tag group and tags - #5923
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #5923 +/- ##
===========================================
+ Coverage 84.81% 84.83% +0.02%
===========================================
Files 1496 1496
Lines 33998 33997 -1
Branches 3622 3622
===========================================
+ Hits 28835 28841 +6
+ Misses 4316 4309 -7
Partials 847 847
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
andrewsparkes
left a comment
There was a problem hiding this comment.
Looks fine. Left a comment.
Have you checked nothing needs changing in the sample manifests for the tag columns and their validations? They might have a limit for the excel sheets for when they upload already tagged samples.
These tags will only be used in new compound sample manifests being created specifically for this kinnex process. That being said the manifests do currently limit to 30 characters, wondering if that should be 60 to reflect the updated model or if its something that should be removed entirely. |
Closes #5755
Changes proposed in this pull request
Additional context
The warehouse limits oligos to 30 characters for flowcell tables. We can't limit oligos at the DB level as prod has tags with oligos of length 99. We can keep the restriction to 30 on manifests and remove it from the model level.