Skip to content

feat: adds Iso-Seq_cDNA_amp_primer tag group and tags - #5923

Open
BenTopping wants to merge 6 commits into
developfrom
Y26-146-kinnex-tags
Open

feat: adds Iso-Seq_cDNA_amp_primer tag group and tags#5923
BenTopping wants to merge 6 commits into
developfrom
Y26-146-kinnex-tags

Conversation

@BenTopping

@BenTopping BenTopping commented Jul 14, 2026

Copy link
Copy Markdown
Contributor

Closes #5755

Changes proposed in this pull request

  • Adds Iso-Seq_cDNA_amp_primer tag group and tags
  • Remove 30 length limit for tag oligos.
    • This remains on the manifests so users should still be protected against copy paste errors.

Additional context

The warehouse limits oligos to 30 characters for flowcell tables. We can't limit oligos at the DB level as prod has tags with oligos of length 99. We can keep the restriction to 30 on manifests and remove it from the model level.

@codecov

codecov Bot commented Jul 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.83%. Comparing base (dc4c12c) to head (7aaccbb).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5923      +/-   ##
===========================================
+ Coverage    84.81%   84.83%   +0.02%     
===========================================
  Files         1496     1496              
  Lines        33998    33997       -1     
  Branches      3622     3622              
===========================================
+ Hits         28835    28841       +6     
+ Misses        4316     4309       -7     
  Partials       847      847              
Flag Coverage Δ
javascript 76.31% <ø> (ø)
ruby 84.69% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BenTopping
BenTopping marked this pull request as ready for review July 16, 2026 14:14

@andrewsparkes andrewsparkes left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Left a comment.

Have you checked nothing needs changing in the sample manifests for the tag columns and their validations? They might have a limit for the excel sheets for when they upload already tagged samples.

Comment thread app/models/tag.rb Outdated
@BenTopping

Copy link
Copy Markdown
Contributor Author

Looks fine. Left a comment.

Have you checked nothing needs changing in the sample manifests for the tag columns and their validations? They might have a limit for the excel sheets for when they upload already tagged samples.

These tags will only be used in new compound sample manifests being created specifically for this kinnex process. That being said the manifests do currently limit to 30 characters, wondering if that should be 60 to reflect the updated model or if its something that should be removed entirely.

@BenTopping
BenTopping requested a review from andrewsparkes July 29, 2026 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y26-146 - Support new tags for Kinnex component samples

2 participants