Skip to content

y24-324 bug around duped aliquots - #2938

Open
andrewsparkes wants to merge 2 commits into
developfrom
y24-324-bug-duped-aliquots-on-tagging
Open

y24-324 bug around duped aliquots#2938
andrewsparkes wants to merge 2 commits into
developfrom
y24-324-bug-duped-aliquots-on-tagging

Conversation

@andrewsparkes

Copy link
Copy Markdown
Member

Closes #1919

Changes proposed in this pull request

Adds a validation to prevent use of an already used tag plate

@codecov

codecov Bot commented Jul 24, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.23%. Comparing base (da08df1) to head (bc3652b).
⚠️ Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #2938   +/-   ##
========================================
  Coverage    92.22%   92.23%           
========================================
  Files          437      437           
  Lines         9235     9245   +10     
========================================
+ Hits          8517     8527   +10     
  Misses         718      718           
Flag Coverage Δ
javascript 89.59% <ø> (ø)
pull_request 92.23% <100.00%> (+<0.01%) ⬆️
push 92.23% <100.00%> (+<0.01%) ⬆️
ruby 92.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@andrewsparkes andrewsparkes changed the title y24-324 bug added validation to check if tag plate used y24-324 bug around duped aliquots Jul 29, 2026

@yoldas yoldas left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried a few used/unused tag plates in Limber console. Looks fine.
The guard to raise error in mixed case is good as well I think.
Thanks for refactoring the tests to make parent and child plates clear.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Y24-324 - [BUG] Creation of duplicate sample in well during robot transfer

2 participants