Skip to content

refactor(adapters): extract shared json and path helpers#103

Merged
samzong merged 1 commit into
mainfrom
refactor/adapter-shared-helpers
Jul 8, 2026
Merged

refactor(adapters): extract shared json and path helpers#103
samzong merged 1 commit into
mainfrom
refactor/adapter-shared-helpers

Conversation

@samzong

@samzong samzong commented Jul 8, 2026

Copy link
Copy Markdown
Owner

What's changed?

  • Add json_util.rs with shared jsonl_indexed, rfc3339_ms, and json_i64 helpers
  • Add paths.rs with resolve_home_dir for consistent ~/… directory resolution
  • Add first_timestamp / last_timestamp in mod.rs for session started_at/updated_at fallback chains
  • Migrate antigravity, claude_code, cline, codex, copilot, cursor, gemini, grok, and pi adapters to the shared helpers
  • Document the new helpers in src/adapters/AGENTS.md

Why

  • Remove duplicated JSONL parsing loops, RFC3339 timestamp coercion, home-dir resolution, and timestamp fallback logic across adapters
  • Centralize coercion behavior (e.g. json_i64 uses i64::try_from for u64) so fixes apply consistently

Verification

  • cargo test (core recall crate): 333 tests passed
  • cargo clippy --workspace --all-targets -- -D warnings: clean
  • cargo fmt --all -- --check: clean

Consolidate duplicated home-dir resolution, JSONL parsing, RFC3339
timestamp coercion, and session timestamp fallback chains into
json_util.rs, paths.rs, and mod.rs helpers used across adapters.

Signed-off-by: samzong <samzong.lu@gmail.com>
@samzong samzong merged commit f295faf into main Jul 8, 2026
1 check passed
@samzong samzong deleted the refactor/adapter-shared-helpers branch July 8, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant