Skip to content

Export conflicts with fetch Response #76

Open

Description

@ryanve

Response is the name used in our root export but the native fetch API adds window.Response as part of that standard. What is the best way to mitigate conflict with this? Rename the export? Ideas? How should we communicate this change?

Activity

  1. amanssit commented on Jul 26, 2019

    @amanssit

    Hi @ryanve I am also getting this issue. Response.js Response object getting conflicts with fetch Response.

  2. ryanve commented on Aug 8, 2019

    @ryanve
    OwnerAuthor

    Ok I'll have to do a new version with a new export name. I'll post here when I do!

  3. ryanve commented on Aug 8, 2019

    @ryanve
    OwnerAuthor

    noConflict restores the fetch Response and returns a reference to the library

    let R = Response.noConflict() 

    See noConflict in the source to see how it works : )

    @amanssit how does that work for you for now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions