Repository navigation
refactor: replace sort.Interface with slices.SortFunc in file browser - #8
Closed
ryans-posthog wants to merge 1 commit into
Closed
ryans-posthog wants to merge 1 commit into
ryans-posthog wants to merge 1 commit into
Conversation
…browse Replace the four custom sort types (byName, byNameDirFirst, bySize, byTime) and their Len/Swap/Less boilerplate with slices.SortFunc, which is more idiomatic in modern Go. This also removes the "sort" import since slices was already in use. Generated-By: PostHog Code Task-Id: 92686f54-3905-423a-8b7f-e9f9f93755ed
ryans-posthog
commented
Apr 16, 2026
ryans-posthog
left a comment
ryans-posthog
left a comment
Owner
Author
There was a problem hiding this comment.
Fix your lint issues and make this significantly more readable.
Comment on lines
+240
to
+260
| cmp = func(a, b fileInfo) int { | ||
| const directoryOffset = -1 << 31 // = -math.MinInt32 | ||
| aSize, bSize := a.Size, b.Size | ||
| if a.IsDir { | ||
| aSize = directoryOffset | ||
| } | ||
| if b.IsDir { | ||
| bSize = directoryOffset | ||
| } | ||
| if a.IsDir && b.IsDir { | ||
| return strings.Compare(strings.ToLower(a.Name), strings.ToLower(b.Name)) | ||
| } | ||
| switch { | ||
| case aSize < bSize: | ||
| return -1 | ||
| case aSize > bSize: | ||
| return 1 | ||
| default: | ||
| return 0 | ||
| } | ||
| } |
Owner
Author
There was a problem hiding this comment.
These new functions are much more unreadable than the previous ones. How many lines were saved if you remove the boilerplate lines of function definitions?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
byName,byNameDirFirst,bySize,byTime) and theirLen/Swap/Lessboilerplate withslices.SortFunccalls"sort"import sincesliceswas already in useTest plan
go build ./modules/caddyhttp/fileserver/...compiles cleanlygo test ./modules/caddyhttp/fileserver/...passesgo test ./caddytest/...integration tests pass