Added more compatibility for Iron's Spells and Spellbooks#708
Closed
gjorgdy wants to merge 3 commits intoryanhcode:mainfrom
Closed
Added more compatibility for Iron's Spells and Spellbooks#708gjorgdy wants to merge 3 commits intoryanhcode:mainfrom
gjorgdy wants to merge 3 commits intoryanhcode:mainfrom
Conversation
…ng used on sublevels
Contributor
|
it would be much better if iron's spells and spellbooks just implemented sable companion, as it was made for this exact reason and all your mixins are just adapting the mod to sable companion. having extra mixins for the mod in base sable means it has to be maintained whenever anything in the original mod changes. |
Author
|
No problem, I will close this PR and submit one for Iron's instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides the game-breaking crash, there were a few smaller issues when using Iron's spells and/or blocks in sublevels.
In this PR I fixed the following issues;
Issues which still exist:
Expands on #700