Skip to content

Added more compatibility for Iron's Spells and Spellbooks#708

Closed
gjorgdy wants to merge 3 commits intoryanhcode:mainfrom
gjorgdy:feature/irons-compat
Closed

Added more compatibility for Iron's Spells and Spellbooks#708
gjorgdy wants to merge 3 commits intoryanhcode:mainfrom
gjorgdy:feature/irons-compat

Conversation

@gjorgdy
Copy link
Copy Markdown

@gjorgdy gjorgdy commented May 2, 2026

Besides the game-breaking crash, there were a few smaller issues when using Iron's spells and/or blocks in sublevels.

In this PR I fixed the following issues;

  • Portal frames detecting players entering when it's placed in a sublevel.
  • Particles of the Touch Dig beam don't calculate all the way to the sublevel plot.

Issues which still exist:

  • When teleporting from the world to a sublevel using a portal frame, the rotation of the sublevel is not accounted for.

Expands on #700

@gjorgdy gjorgdy marked this pull request as draft May 2, 2026 14:52
@tazercopter
Copy link
Copy Markdown
Contributor

it would be much better if iron's spells and spellbooks just implemented sable companion, as it was made for this exact reason and all your mixins are just adapting the mod to sable companion. having extra mixins for the mod in base sable means it has to be maintained whenever anything in the original mod changes.

@gjorgdy
Copy link
Copy Markdown
Author

gjorgdy commented May 2, 2026

No problem, I will close this PR and submit one for Iron's instead.

@gjorgdy gjorgdy closed this May 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants