Prevent Todo shortcuts from firing during shortcut recording#1792
Open
culpen90 wants to merge 1 commit into
Open
Prevent Todo shortcuts from firing during shortcut recording#1792culpen90 wants to merge 1 commit into
culpen90 wants to merge 1 commit into
Conversation
culpen90
marked this pull request as ready for review
July 18, 2026 16:38
Owner
|
Thanks for contributing! #195 is a little different from this scenario, and some of the keyboard shortcut recording behavior has changed since that issue was filed. I'll give this a thorough test, but it looks good up front. I'll probably remove the auto-close of #195 since it's still valid in a more general sense than just Todo mode. |
Contributor
Author
|
Thanks for the context—that makes sense. I updated the PR description to reference #195 without auto-closing it, so the broader shortcut-recording issue stays open. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Context
Window-action bindings are already suspended during shortcut recording. Todo shortcuts use separate MASShortcut registrations, so they could remain active and trigger Rectangle behavior while a new shortcut was being entered.
Testing
mainreport the same 21 unrelated cooperative-resize assertion failures. The branch adds three passing tests, for 173 total tests versus 170 on the upstream baseline.Related to #195