Repository navigation
Conversation
Member
|
At 42 recent downloads (the pull request template asked for recent downloads, not all-time downloads), this crate doesn't meet our notability criteria: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Affected crate(s)
caja(~5.5k total downloads on crates.io) — all versions before 0.3.2Links to upstream issue(s) or PR(s)
as_mut_slice(&self)lets safe code create aliasing&mut [T]EmanuelGCC/Caja#3Severity
Caja::as_mut_slice()takes&selfbut returns&mut [T]over the whole array.Since any number of shared borrows of a
Cajacan exist, calling it twice gives twolive mutable slices of the same elements, which breaks Rust's aliasing rules. A write
through one slice is visible through the other, and Miri reports the access as
undefined behavior.
Filed as a soundness issue: no
unsafeis required from the caller, and the effectis aliasing
&mutreferences (undefined behavior), not a demonstrated memorycorruption.
Checklist
RUSTSEC-0000-0000as the IDdatefield is set to the public disclosure date