Add try_value methods to reply structs - #295
Open
mina86 wants to merge 1 commit into
Open
Conversation
The `value` method of reply structs (such as `GetPropertyReply`) panic if the format of the reply does not match the format of the property. This forces user to check the format which is then later checked in the method duplicating the condition. Since the method already knows the correct format, a more user-friendly and less error-prone approach is for the method to perform the check and return an error-condition if it fails. This is what `try_value` method does.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
valuemethod of reply structs (such asGetPropertyReply) panic if the format of the reply does not match the format of the property. This forces user to check the format which is then later checked in the method duplicating the condition.Since the method already knows the correct format, a more user-friendly and less error-prone approach is for the method to perform the check and return an error-condition if it fails. This is what
try_valuemethod does.