Repository navigation
Conversation
emilio
requested changes
Sep 23, 2026
| let spelling = token.spelling(); | ||
| if looking_for_name { | ||
| // Skip C++ attributes before the namespace name or `{`. | ||
| match spelling { |
Contributor
There was a problem hiding this comment.
Seems we don't need this to be separate to the match right below, or am I missing something?
Contributor
Author
There was a problem hiding this comment.
Agreed, the separate match was unnecessary. I folded the attribute-depth arms into the existing token match in 4e80951. The namespace-attributes header test and nightly formatting check pass.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3485.
When libclang leaves the spelling of an anonymous namespace empty,
tokenize_namespacereads its tokens to identify the name. A C++ attribute before{made it treat[as a module name and panic. Skip the bracketed attribute sequence while looking for the namespace name, so an attributed anonymous namespace is handled like an ordinary anonymous namespace. Named namespaces remain covered by the same fixture.Added a C++17 header regression test with both anonymous and named attributed namespaces. Verified the new test fails with the reported panic before the change and passes afterward. Also ran the existing inline/nested namespace tests,
cargo test -p bindgen, the generated expectation compilation, formatting, and workspace Clippy with warnings denied.AI assistance: Codex helped prepare the change and tests; I reviewed and ran the checks above.