fix(resolve): detect unused patches when multiple patches share a PackageId#16987
Open
raushan728 wants to merge 2 commits into
Open
fix(resolve): detect unused patches when multiple patches share a PackageId#16987raushan728 wants to merge 2 commits into
raushan728 wants to merge 2 commits into
Conversation
rustbot
added
A-dependency-resolution
Collaborator
|
r? @weihanglo rustbot has assigned @weihanglo. Use Why was this reviewer chosen?The reviewer was selected based on:
|
0xPoe
reviewed
May 11, 2026
0xPoe
reviewed
May 11, 2026
…kageId Previously, Cargo tracked used patches solely by PackageId. If multiple sources patched the same dependency, unused patches were incorrectly marked as used. This updates the logic to track usage by both source URL and PackageId in-memory, ensuring accurate warnings while keeping Cargo.lock backward-compatible. Fixes rust-lang#12471
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #12471
Previously, Cargo determined patch usage solely by checking if the
PackageIdexisted in the crate graph, which caused false positives if multiple patch sources pointed to the same dependency.Updated
register_used_patchesandemit_warnings_of_unused_patchesto independently verify patch usage by inspecting graph edges for specific(CanonicalUrl, PackageId)pairs.Left
Resolve::unused_patchesasVec<PackageId>to ensure strictCargo.lockbackward compatibility without altering the serialized format.