test: sync read after connection closed - #163
Merged
nyonson merged 1 commit intoJan 13, 2026
Merged
Conversation
This implements the sync variant of 0719bcc. While this works at the moment, I think it's good to have this test for extra coverage. It can also be easily extended in a follow up to test sync write() on a closed socket (see rust-bitcoin#160 (comment)).
Member
|
ACK eaea29e |
rustaceanrob
approved these changes
Jan 9, 2026
nyonson
approved these changes
Jan 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This implements the sync variant of 0719bcc. While it works at the moment, I think it's good to have this test for extra coverage. It can also be easily extended in a follow up to test (the currently broken) sync
write()on a closed socket (see #160 (comment)).