Conversation
A kwarg without a default value (e.g. `def foo a:`) followed by a newline-and-body had its trailing newline eaten by `skip_space_or_newline` in visit_params. With no newline left, indent_body folded the body onto the same line, producing syntactically invalid output like `def foo a: ...body... end`. Skip only spaces when the label has no default value; the consume_space path already handles space+newline for the value-bearing case. Fixes #331
The spec relies on shorthand hash literal `{ uid: }`, which is Ruby 3.1+
syntax, so it cannot be parsed on Ruby 3.0. Move it under 3.1/ so it is
only loaded on supported versions.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref: #331