feat(hooks): add omp (Oh My Pi) agent support - #3736
Closed
abcabc0330 wants to merge 1 commit into
Closed
Conversation
omp is the successor to the Pi coding agent and exposes the same extension API. Add an `rtk init --agent omp` install/uninstall path that writes the shared rtk extension to the omp agent directory (`~/.omp/agent/extensions` or project-local `.omp/agent/extensions`), honoring PI_CODING_AGENT_DIR. - AgentTarget::Omp variant + --agent omp CLI value - run_omp_mode / uninstall_omp (mirrors Pi mode, omp directory) - hooks/omp/README.md, hooks/pi/README.md cross-reference - README + hooks README: supported-agents table and install list - 5 unit tests covering global/local install, uninstall, dry-run Closes: omp extension parity with Pi
|
|
Author
|
Closing in favor of #3707 (feat(omp): add Oh My Pi (OMP) support by @alvins82), which is a superset of this PR:
No unique content in this PR that #3707 lacks. Merging #3707 fully covers omp support. Thanks @alvins82 for the thorough implementation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add support for Oh My Pi (omp) — the successor to the Pi coding agent — to the RTK hook installer. omp exposes the same extension API as Pi, so the existing
rtk.tsextension works unchanged; this PR wires uprtk init --agent ompto install it into the omp agent directory.What changed
AgentTarget::Omp+--agent ompCLI valuerun_omp_mode/uninstall_ompinsrc/hooks/init.rs— mirror Pi mode but target the omp agent directory:~/.omp/agent/extensions/rtk.ts(honorsPI_CODING_AGENT_DIR).omp/agent/extensions/rtk.tsOMP_DIR(.omp/agent),OMP_EXTENSIONS_SUBDIR,OMP_PLUGIN_FILEhooks/omp/README.md, cross-reference inhooks/pi/README.md, supported-agents table + install list inhooks/README.mdand rootREADME.mdNotes
hooks/pi/rtk.ts); omp only differs in install location.PI_CODING_AGENT_DIR(the same env var Pi uses), defaulting to~/.omp/agent.Verification
cargo clippycleanrtk init --agent omp --globalinstalls to~/.omp/agent/extensions/rtk.ts;rtk init --uninstall --agent omp --globalremoves it