fix: resolve failing CI checks - tryCatch handler, top-level return(), flow-typed install#103
Draft
fix: resolve failing CI checks - tryCatch handler, top-level return(), flow-typed install#103
Conversation
…ow-typed install Agent-Logs-Url: https://github.com/rstudio/reactlog/sessions/fa714002-0190-4876-bcdc-33c3a8eabae7 Co-authored-by: karangattu <4220325+karangattu@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix automated checks failing for reactlog package on main
fix: resolve failing CI checks - tryCatch handler, top-level return(), flow-typed install
Apr 27, 2026
This was referenced Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three distinct CI failures on
maintriggered by the shinycoreci scheduled check run.Fixes
tryCatcherror handler missing condition arg (R/shinyModule.R):error = function()must beerror = function(cond)— newer R versions enforce this, causingError in value[[3L]](cond): unused argument (cond)intest-shiny_module.R:21.Top-level
return()in example (R/shinyModule.R,man/reactlog_module.Rd): Theif (!require("shiny")) { return() }guard fails withno function to return fromwhen executed at the top level (exposed by thecheck-depends-onlyjob which omits Suggests). Replaced with theif (require("shiny")) { ... }pattern.flow-typed installbreakingyarn install(bin/postinstall.sh):flow-typed installfetches from GitHub at install time and was exiting 1 withUNCAUGHT ERROR: [{}, ...], failing the entireyarn install --immutablestep. Made non-fatal with|| true.