Skip to content

fix: resolve failing CI checks - tryCatch handler, top-level return(), flow-typed install#103

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/automated-fix-reactlog-checks
Draft

fix: resolve failing CI checks - tryCatch handler, top-level return(), flow-typed install#103
Copilot wants to merge 2 commits intomainfrom
copilot/automated-fix-reactlog-checks

Conversation

Copy link
Copy Markdown

Copilot AI commented Apr 27, 2026

Three distinct CI failures on main triggered by the shinycoreci scheduled check run.

Fixes

  • tryCatch error handler missing condition arg (R/shinyModule.R): error = function() must be error = function(cond) — newer R versions enforce this, causing Error in value[[3L]](cond): unused argument (cond) in test-shiny_module.R:21.

    # Before
    tryCatch({...}, error = function() { FALSE })
    # After
    tryCatch({...}, error = function(cond) { FALSE })
  • Top-level return() in example (R/shinyModule.R, man/reactlog_module.Rd): The if (!require("shiny")) { return() } guard fails with no function to return from when executed at the top level (exposed by the check-depends-only job which omits Suggests). Replaced with the if (require("shiny")) { ... } pattern.

  • flow-typed install breaking yarn install (bin/postinstall.sh): flow-typed install fetches from GitHub at install time and was exiting 1 with UNCAUGHT ERROR: [{}, ...], failing the entire yarn install --immutable step. Made non-fatal with || true.

Note: The macOS-latest (4.6.0) failure (HTTP 404 on R download) is external — R 4.6.0 binaries were not yet available at run time and is not addressable in this repo.

…ow-typed install

Agent-Logs-Url: https://github.com/rstudio/reactlog/sessions/fa714002-0190-4876-bcdc-33c3a8eabae7

Co-authored-by: karangattu <4220325+karangattu@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix automated checks failing for reactlog package on main fix: resolve failing CI checks - tryCatch handler, top-level return(), flow-typed install Apr 27, 2026
Copilot AI requested a review from karangattu April 27, 2026 20:28
@karangattu karangattu requested a review from schloerke April 27, 2026 20:48
@karangattu karangattu removed their request for review April 27, 2026 20:51
@karangattu karangattu removed their assignment Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automated fix: reactlog package checks failing on main

3 participants