Repository navigation
use lower case guid in template - #1018
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
No unresolved review issues were identified.
0 open findings
What changed in this PR
Updates the SQL project template to generate lowercase GUIDs for consistency.
Changes:
- Changes the GUID generator format from
Dtod.
| File | Description |
|---|---|
src/MSBuild.Sdk.SqlProj.Templates/templates/sqlproj/.template.config/template.json |
Configures lowercase GUID generation. |
🧠 Review effort: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
ErikEJ
requested review from
GoEddie,
jeffrosenberg,
jmezach and
paulomorgado
October 16, 2026 12:53
Collaborator
Author
|
dotnet new sqlproj: <Project Sdk="MSBuild.Sdk.SqlProj/4.4.0">
<PropertyGroup>
<TargetFramework>net10.0</TargetFramework>
<SqlServerVersion>SqlAzure</SqlServerVersion>
<RunSqlCodeAnalysis>True</RunSqlCodeAnalysis>
<GenerateEntityRelationshipDiagram>False</GenerateEntityRelationshipDiagram>
<ProjectGuid>FD9A52F8-9A23-47EE-918C-402564051A6D</ProjectGuid>
<!-- For additional properties that can be set here, please refer to https://rr-wfm.github.io/MSBuild.Sdk.SqlProj/docs/project-configuration.html#model-properties -->
</PropertyGroup>
<ItemGroup>
<!-- This package adds additional code analysis rules -->
<!-- We recommend using it, but it can be removed if desired -->
<PackageReference Include="ErikEJ.DacFX.SqlServer.Rules" Version="5.1.2">
<PrivateAssets>all</PrivateAssets>
<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
</PackageReference>
</ItemGroup>
<PropertyGroup>
<!-- Refer to https://rr-wfm.github.io/MSBuild.Sdk.SqlProj/docs/publishing.html for supported publishing options -->
</PropertyGroup>
</Project>
Origin.xml of built package: <DacOrigin xmlns="http://schemas.microsoft.com/sqlserver/dac/Serialization/2012/02">
<ModelSchemaVersion>3.3</ModelSchemaVersion>
<ProjectGuid>fd9a52f8-9a23-47ee-918c-402564051a6d</ProjectGuid>
</DacOrigin> |
paulomorgado
approved these changes
Oct 16, 2026
nmummau
approved these changes
Oct 17, 2026
jmezach
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for consistency
see https://github.com/dotnet/templating/blob/main/docs/Available-Symbols-Generators.md#guid
fixes #1017