Skip to content

use lower case guid in template - #1018

Merged
jmezach merged 1 commit into
rr-wfm:masterfrom
ErikEJ:issue-1017
Oct 19, 2026
Merged

jmezach merged 1 commit into
rr-wfm:masterfrom
ErikEJ:issue-1017

Conversation

@ErikEJ

@ErikEJ ErikEJ commented Oct 16, 2026 •

Copy link
Copy Markdown
Collaborator

@ErikEJ ErikEJ changed the title use lower case giúid in template use lower case guid in template Oct 16, 2026
@ErikEJ
ErikEJ requested a lite review from Copilot October 16, 2026 12:51

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

No unresolved review issues were identified.

0 open findings

What changed in this PR

Updates the SQL project template to generate lowercase GUIDs for consistency.

Changes:

  • Changes the GUID generator format from D to d.
File Description
src/​MSBuild.Sdk.SqlProj.Templates/​templates/​sqlproj/​.template.config/​template.json Configures lowercase GUID generation.

🧠 Review effort: Lite


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@ErikEJ

ErikEJ commented Oct 16, 2026

Copy link
Copy Markdown
Collaborator Author

dotnet new sqlproj:

<Project Sdk="MSBuild.Sdk.SqlProj/4.4.0">
    <PropertyGroup>
        <TargetFramework>net10.0</TargetFramework>
        <SqlServerVersion>SqlAzure</SqlServerVersion>
        <RunSqlCodeAnalysis>True</RunSqlCodeAnalysis>
        <GenerateEntityRelationshipDiagram>False</GenerateEntityRelationshipDiagram>
        <ProjectGuid>FD9A52F8-9A23-47EE-918C-402564051A6D</ProjectGuid>
        <!-- For additional properties that can be set here, please refer to https://rr-wfm.github.io/MSBuild.Sdk.SqlProj/docs/project-configuration.html#model-properties -->
    </PropertyGroup>

    <ItemGroup>
        <!-- This package adds additional code analysis rules -->
        <!-- We recommend using it, but it can be removed if desired -->
        <PackageReference Include="ErikEJ.DacFX.SqlServer.Rules" Version="5.1.2">
          <PrivateAssets>all</PrivateAssets>
          <IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
        </PackageReference>
    </ItemGroup>


    <PropertyGroup>
        <!-- Refer to https://rr-wfm.github.io/MSBuild.Sdk.SqlProj/docs/publishing.html for supported publishing options -->
    </PropertyGroup>
</Project>

Origin.xml of built package:

<DacOrigin xmlns="http://schemas.microsoft.com/sqlserver/dac/Serialization/2012/02">
    <ModelSchemaVersion>3.3</ModelSchemaVersion>
    <ProjectGuid>fd9a52f8-9a23-47ee-918c-402564051a6d</ProjectGuid>
</DacOrigin>

@jmezach
jmezach merged commit 8331763 into rr-wfm:master Oct 19, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

projectGuid generated in upper case, for consistency it should be lower

5 participants