Conversation
Release vtable and cursor handles when SQLite destroys them
Do not clobber SQLite's default cost estimates in BestIndex
Translate SQL NULL filter arguments to nil like goVUpdate
Identify updated row by argv 0 in goVUpdate
Ignore Used for constraints SQLite marked not usable
Reject nil module and nil BestIndex result
Fail upgrade tool on download and write errors
Fix off-by-one truncating SQL in fuzz target
Fix wrong results and cursor state sharing in series example
Use the table name from xCreate args in vtable example
Close leaked rows in hook example
Close prepared statement and fail if limit is not enforced in limit example
Upgrade SQLite to version 3053004
Handle NULL and BLOB values in json example Scan
Add workflow to create releases on tag push
SQLite retains p->pVtab when xDestroy returns an error and later calls xDisconnect on the same object (during sqlite3VtabUnlock or close). Deleting the Go-side handle on the xDestroy error path made that later xDisconnect panic with a nil type assertion in goVRelease. Release the handle only after a successful xDestroy (or any xDisconnect, where SQLite always discards the object). Found in the 0xCarbon fork's SQLCipher sync; regression test panics on the previous code.
fix: keep vtab handle registered when xDestroy fails
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.