Repository navigation
Fix content negotiation (q-values, Vary: Accept) - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isMarkdownRequested()previously did a substring match on theAcceptheader, which incorrectly returned true for clients that listedtext/markdownbut preferredtext/html(e.g.Accept: text/html, text/markdown;q=0.5). It now parses per RFC 9110, picking the most specific matching entry and only returning true when markdown's q-value strictly exceeds html's.Also emits
Vary: Accepton every front-end response (not just the markdown ones) so downstream caches can't cross-serve an HTML response to a later Markdown request for the same URL. Can be disabled via thepost_content_to_markdown/emit_varyfilter; Markdown responses keep their own explicitVaryregardless.