[civetweb] download instead of bundle, bump from 1.15 to 1.16, and define proper CMake target#21947
Open
ferdymercury wants to merge 19 commits intoroot-project:masterfrom
Open
[civetweb] download instead of bundle, bump from 1.15 to 1.16, and define proper CMake target#21947ferdymercury wants to merge 19 commits intoroot-project:masterfrom
ferdymercury wants to merge 19 commits intoroot-project:masterfrom
Conversation
Test Results 18 files 18 suites 2d 15h 28m 48s ⏱️ For more details on these failures, see this check. Results for commit 42f4ad9. ♻️ This comment has been updated with latest results. |
ferdymercury
commented
Apr 20, 2026
| ${FASTCGI_LIBRARY} | ||
| ${CMAKE_DL_LIBS} | ||
| civetweb::civetweb | ||
| DEPENDENCIES |
Collaborator
Author
There was a problem hiding this comment.
TO-DO: discuss if builtin_civetweb=OFF should be discouraged, by emitting a warning or better describing ROotBuildOptions text.
See discussion root-project/root-ci-images#110 (comment)
ferdymercury
added
the
skip code analysis
Collaborator
Author
|
@linev for Fedora we'd need root-project/root-ci-images#111 |
This was referenced Apr 21, 2026
ferdymercury
commented
Apr 21, 2026
| endif() | ||
| endif() | ||
| if (NOT builtin_civetweb) | ||
| target_compile_definitions(civetweb::civetweb INTERFACE _EXTERNAL_CIVETWEB) # temporary hack for: with external civetweb one gets failure R__memcompress |
Collaborator
Author
There was a problem hiding this comment.
TO-DO investigate
ferdymercury
commented
Apr 21, 2026
| endif() | ||
| endif() | ||
|
|
||
| #--- Check for civetweb - (has to after SSL) ------------------------------------------ |
Collaborator
Author
There was a problem hiding this comment.
Suggested change
| #--- Check for civetweb - (has to after SSL) ------------------------------------------ | |
| #--- Check for civetweb - (has to go after SSL) --------------------------------------- |
ferdymercury
commented
Apr 21, 2026
and copy-paste additional variables from xrootd to civetweb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.