Repository navigation
fix(audio): prevent right-only input from triggering silence gate - #484
Closed
saiedhosni wants to merge 1 commit into
Closed
saiedhosni wants to merge 1 commit into
saiedhosni wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
When stereo input contains signal only on the right channel, FineTune samples only channel 0 for its peak/silence decision. The output gate can then treat audible input as silence and mute it after 200 ms.
Change
Scan every Float sample in every input buffer using an allocation-free, real-time-safe helper. Preserve the existing frame-count calculation and unity peak clamp. Add regression coverage for left=0/right=0.5 stereo input and peak clamping.
Validation
Related upstream reports: #429 and #479. This addresses the same peak-scanning problem as #479.