Repository navigation
feat(audio): add per-app mono playback to both stereo channels - #454
Open
principalwater wants to merge 1 commit into
Open
principalwater wants to merge 1 commit into
principalwater wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add an opt-in mono playback toggle to every app row. FineTune averages the app's stereo source pair and sends the result to both channels of the destination device's preferred stereo pair. It leaves other apps in stereo and keeps the app's existing device routing, including Follow System Default.
The setting is saved per app, works for pinned inactive apps, and is applied before the tap starts. The audio callback uses only stack values and existing buffers.
Why
This provides a general per-app version of macOS's “Play stereo audio as mono” setting. For example, a call app may output remote audio in only one channel; per-app mono plays it through both speakers while music from other apps remains stereo. There is no app-specific detection or special case.
Addresses #323. Complements #392, which routes summed audio to one physical output channel for interface splitting; this feature sends mono to both channels of the selected stereo pair. It uses a conventional
(L + R) / 2fold-down; a one-sided source is 6 dB quieter, as with #392, and can be raised with FineTune's existing app volume/boost controls.Verification
xcodebuild test -project FineTune.xcodeproj -scheme FineTune -configuration Debug -destination 'platform=macOS,arch=arm64' -skip-testing:FineTuneUITests CODE_SIGN_IDENTITY=- CODE_SIGNING_REQUIRED=NO— 772 passed, 0 failed.