Repository navigation
Conversation
Map URL percentages through the existing slider curve, read restored volume after unmute, and respect non-DDC backend overrides during probe restoration. Refs ronitsingh10#434, ronitsingh10#376, ronitsingh10#374.
lucascossitt
added a commit
to lucascossitt/FineTune
that referenced
this pull request
Sep 17, 2026
…onitsingh10#434) finetune://set-volumes?app=…&volume=10 wrote a linear gain of 0.10, which the x² slider shows as 32%. App percentages now go through VolumeMapping.sliderToGain so the popup shows the requested value. Device volume keeps the linear scalar, which the driver already tapers. Ported from upstream PR ronitsingh10#445 (URL part only; its HUD-unmute and DDC-restore fixes were already in integration via ronitsingh10#412). Tests from the PR. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three volume-control issues using the existing mapping and control paths:
set-volumes?...&volume=10now displays 10% rather than approximately 32%. Active and inactive apps use the same slider-to-gain conversion, and step-volume logging reports the displayed percentage. The URL guide now documents the supported 0–100 range and separate boost setting.Closes #434. Closes #376. Closes #374.
Validation: URL and software-unmute regression tests failed before the fix and passed afterward. All 48 targeted Debug tests passed on this standalone branch and cover active/inactive URL volumes, invalid values, media-key handling, volume mapping, and backend override settings. Physical DDC display launch/reconnect behavior has not been manually verified.
Related proposals: #406 and #412 also address the HUD/DDC issues. This patch uses a deferred read of the existing volume argument and keeps production changes to three files, with seven net added lines.