Security enhancements - #116
Merged
Merged
Conversation
Clears the two high-severity advisories failing the audit gate (brace-expansion, ip-address) via version-scoped dev overrides. Both are dev-only transitives with no fixed parent release, and each override stays within the existing major line so no consumer is moved across a breaking boundary. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
TwitchBronBron
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the two high-severity advisories that were failing
npm run audit.npm audit --omit=dev: 0 vulnerabilities across the 2 runtime deps (promises,rodash) — consumers were never exposed by any of these. Full audit went 5 → 3, with zero high remaining (the 3 are all below the gate'shighfloor).Ships to consumers
Nothing. Both advisories are dev-only, and the
overridesblock added here is not inherited by consumers.Lockfile only (dev deps)
Both are dev-only transitives with no fixed parent release, so
overridesis the only lever.brace-expansionis pinned to its v1 line since that's the only major present.brace-expansionrooibos-roku→minimatch@3^1.1.18ip-addressbrighterscript→roku-deploy→postman-request→socks^10.3.1Notes for the reviewer
qs,uuid) are moderate and don't fail the gate. Theuuidaudit-ci.jsoncallowlist entry is kept as-is.npm run testneeds a real Roku device, so it wasn't run here;preversion(ropm copy + bsc compile + dist build) is the full offline gate and passes.Verification
npm run preversionpasses — ropm copy,bsccompile with no diagnostics, and dist build.🤖 Generated with Claude Code