Security enhancements - #41
Merged
Merged
Conversation
Clears the three high-severity advisories failing the audit gate (brace-expansion, js-yaml, ip-address) via version-scoped dev overrides. All three are dev-only transitives with no fixed parent release, and each override stays within the existing major line so no consumer is moved across a breaking boundary. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
TwitchBronBron
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the three high-severity advisories that were failing
npm run audit.npm audit --omit=dev: 0 vulnerabilities — this package has no runtime dependencies, so consumers were never exposed by any of these. Full audit went 9 → 6, with zero high remaining (the 6 are all below the gate'shighfloor).Ships to consumers
Nothing. There are no
dependencies, onlydevDependencies.Lockfile only (dev deps)
All three are dev-only transitives with no fixed parent release, so
overridesis the only lever. Each is version-scoped to keep both major lines in the tree on their own line — no consumer gets moved across a breaking boundary.brace-expansionbrighterscript→minimatch@3,mocha→minimatch@5^1.1.18/^2.1.4js-yamleslint,mocha,nyc→@istanbuljs/load-nyc-config^3.15.1/^4.3.1ip-addressbrighterscript→roku-deploy→postman-request→socks^10.3.1Notes for the reviewer
npm audit fixwas tried first and thrown away: it churned 1302 lockfile lines and re-resolvedpostman-request's tree in a way that introduced two criticalform-dataadvisories. The targeted overrides here touch 85 lines and add nothing.uuidone still needs a breakingnyc@18bump — recommend leaving it, and itsaudit-ci.jsoncallowlist entry is kept as-is.Verification
npm run preversionpasses — build, lint, and 19 tests green.🤖 Generated with Claude Code