Repository navigation
fix(rivetkit): release HTTP cancellation resources - #5939
Draft
NathanFlurry wants to merge 1 commit into
Draft
NathanFlurry wants to merge 1 commit into
NathanFlurry wants to merge 1 commit into
Conversation
NathanFlurry
commented
Oct 29, 2026
Member
- Cancel completed and failed HTTP requests while preserving streaming-response lifetimes.
- Release native and WebAssembly cancellation subscriptions and share one actor abort bridge per activation.
- Add regression coverage for repeated requests, actor shutdown, and listener disposal.
- Verify with 364 core tests, 31 TypeScript/native tests, typechecking, and native/Wasm build checks.
|
🚅 Deployed to the rivet-pr-5939 environment in rivet-frontend
6 services not affected by this PR
|
Contributor
📟 Pip-Boy ·
|
| package (linux-x64-gnu) | @latest |
base | this PR | Δ vs base | packages |
|---|---|---|---|---|---|
@rivet-dev/workflow-world |
359.2 MB | 359.5 MB | 359.5 MB | +7.7 KB (+0.0%) | 103 (0) |
@rivetkit/cloudflare-workers |
357.8 MB | 358.0 MB | 358.0 MB | +7.7 KB (+0.0%) | 98 (0) |
@rivetkit/effect |
411.4 MB | 411.6 MB | 411.7 MB | +7.7 KB (+0.0%) | 99 (0) |
@rivetkit/engine-api-full |
3.6 MB | 3.6 MB | 3.6 MB | 0 | 44 (0) |
@rivetkit/engine-envoy-protocol |
234.9 KB | 245.9 KB | 245.9 KB | 0 | 2 (0) |
@rivetkit/engine-runner |
2.2 MB | 2.3 MB | 2.3 MB | 0 | 19 (0) |
@rivetkit/engine-runner-protocol |
166.3 KB | 177.3 KB | 177.3 KB | 0 | 2 (0) |
@rivetkit/engine-test-runner |
3.7 MB | 3.8 MB | 3.8 MB | 0 | 22 (0) |
@rivetkit/framework-base |
357.9 MB | 358.1 MB | 358.1 MB | +7.7 KB (+0.0%) | 100 (0) |
@rivetkit/next-js |
365.9 MB | 366.1 MB | 366.2 MB | +7.7 KB (+0.0%) | 107 (0) |
@rivetkit/react |
365.9 MB | 366.1 MB | 366.1 MB | +7.7 KB (+0.0%) | 106 (0) |
@rivetkit/sql-loader |
13.5 KB | 24.5 KB | 24.5 KB | 0 | 1 (0) |
@rivetkit/supabase |
9.7 MB | 9.7 MB | 9.7 MB | +1.4 KB (+0.0%) | 20 (0) |
@rivetkit/traces |
2.6 MB | 2.6 MB | 2.6 MB | 0 | 9 (0) |
@rivetkit/virtual-websocket |
30.9 KB | 42.0 KB | 42.0 KB | 0 | 1 (0) |
@rivetkit/workflow-engine |
4.3 MB | 4.3 MB | 4.3 MB | 0 | 22 (0) |
rivetkit |
357.7 MB | 357.9 MB | 357.9 MB | +7.7 KB (+0.0%) | 97 (0) |
🧹 Rust dependencies · cargo deny + cargo shear
| check | new in this PR | fixed | existing on base |
|---|---|---|---|
| advisories | ✅ 0 | 0 | 39 |
| licenses | ✅ 0 | 0 | 0 |
| sources | ✅ 0 | 0 | 0 |
| bans | ✅ 0 | 0 | 0 |
| unused | ✅ 0 | 0 | 292 |
🦀 Binaries · publish Dockerfiles, --release
Base: main@4a2cd74, the merge base.
| artifact | npm @latest |
base | this PR | Δ vs base |
|---|---|---|---|---|
engine linux-x64-musl |
93.9 MB | 93.9 MB | 93.9 MB | 0 |
rivetkit-napi linux-x64-gnu |
44.0 MB | 44.0 MB | 44.1 MB | +12.7 KB (+0.0%) |
⏱ Timing
| job | wall time | slowest step |
|---|---|---|
zizmor |
11s | setup-uv · 3s |
changes |
19s | checkout · 14s |
native · engine · linux-x64-musl |
13m27s | Build with the publish Dockerfile · 13m10s |
footprint |
2m03s | Pack this commit · 45s |
hygiene |
59s | checkout · 15s |
native · rivetkit-napi · linux-x64-gnu |
5m15s | Build with the publish Dockerfile · 5m01s |
⏭ self-test |
— | skipped |
report |
16s | setup-node · 4s |
🔭 Full CI trace for this commit
One OpenTelemetry trace of Rust CI, frontend, and Pip-Boy for b5798b7: every job and step, with the sizes above attached. Run after CI finishes.
pnpm install --frozen-lockfile --filter 'pipboy...'
pnpm --filter pipboy pipboy trace --sha b5798b7b5c8332ae2afcf08f47188fc3beeb90f5Add --otlp <url> to send it to any OTLP/HTTP collector.
Agent instruction: From a rivet-dev/rivet checkout, run the commands above, then read the trace file the last command prints. List the slowest jobs and steps and explain where CI time went.
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.