You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The Geant4 merge macro currently does not fully preserve or validate all metadata needed in merged restG4 ROOT files.
Update: PR #153 addresses the metadata-preservation and metadata-validation part of this issue. The AnalysisTree merge behavior remains a separate design/policy question.
Related prior work:
geant4lib Merge supports analysis files #114: adds support for merging analysis files, but is stale/conflicting and only partially addresses metadata handling.
restG4 Add validation for merge files restG4#101: adds a limited merge validation test for older merge work, but does not validate metadata compatibility or analysis-tree correctness.
Observed / diagnosed problems:
TRestGeant4Metadata copy/merge behavior can drop particle-source information.
TRestGeant4PhysicsLists is not robustly validated/preserved by the current merge path.
Input files are assumed compatible, but compatibility is not checked.
The Geant4 merge macro currently does not fully preserve or validate all metadata needed in merged restG4 ROOT files.
Update: PR #153 addresses the metadata-preservation and metadata-validation part of this issue. The AnalysisTree merge behavior remains a separate design/policy question.
Related prior work:
Observed / diagnosed problems:
TRestGeant4Metadatacopy/merge behavior can drop particle-source information.TRestGeant4PhysicsListsis not robustly validated/preserved by the current merge path.TFileMergerbut allows duplicate event IDs.Expected fix:
The merge should also validate that all input files were produced with compatible simulation metadata:
TRestGeant4PhysicsLists;TRestGeant4Metadata::GetGeant4Version();