Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1391
Description
This PR fixes full-page screenshots for websites containing viewport-relative elements such as
height: 100vh.The screenshot process now preserves the original device viewport, scrolls through the page, captures each visible section, and stitches the sections into one full-page image.
Reason for Change
Previously, full-page screenshots resized the webview to match the document height. This caused elements using viewport units to stretch across the entire screenshot.
Other capture approaches could also produce duplicated sections, black areas, or omit the footer.
Capture Behavior
vhunitsPreview