Repository navigation
Add to_sync attribute set by KonfluxSource [RHELDST-45462] - #724
Merged
crungehottman merged 1 commit intoNov 4, 2026
Merged
crungehottman merged 1 commit into
crungehottman merged 1 commit into
Conversation
crungehottman
requested review from
chandwanitulsi,
rajulkumar and
rbikar
as code owners
November 2, 2026 21:29
Member
Author
|
CI is failing on |
rbikar
approved these changes
Nov 4, 2026
crungehottman
force-pushed
the
konflux-to-sync-attribute
branch
from
November 4, 2026 14:27
4f29615 to
47de8a5
Compare
Consumers (e.g. pubtools-pulp) need to know which items must be synced into the target system from a remote source rather than uploaded from local content. Until now this was inferred from the absence of an opener (or the shape of src), which is fragile: an item may legitimately have opener=None with an ordinary string source. Add an explicit to_sync bool on PushItem (default False) and set it to True on the RPM items produced by KonfluxSource, whose content lives in a remote Pulp referenced by src. Consumers should rely on this flag. Baseline cases are regenerated to include the new field. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
crungehottman
force-pushed
the
konflux-to-sync-attribute
branch
from
November 4, 2026 14:41
47de8a5 to
9531f62
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #724 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 59 59
Lines 2875 2877 +2
=========================================
+ Hits 2875 2877 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Consumers (e.g. pubtools-pulp) need to know which items must be synced into the target system from a remote source rather than uploaded from local content. Until now this was inferred from the absence of an opener (or the shape of src), which is fragile: an item may legitimately have opener=None with an ordinary string source.
Add an explicit to_sync bool on PushItem (default False) and set it to True on the RPM items produced by KonfluxSource, whose content lives in a remote Pulp referenced by src. Consumers should rely on this flag.
Baseline cases are regenerated to include the new field.