Skip to content

Add to_sync attribute set by KonfluxSource [RHELDST-45462] - #724

Merged
crungehottman merged 1 commit into
release-engineering:masterfrom
crungehottman:konflux-to-sync-attribute
Nov 4, 2026
Merged

crungehottman merged 1 commit into
release-engineering:masterfrom
crungehottman:konflux-to-sync-attribute

Conversation

@crungehottman

Copy link
Copy Markdown
Member

Consumers (e.g. pubtools-pulp) need to know which items must be synced into the target system from a remote source rather than uploaded from local content. Until now this was inferred from the absence of an opener (or the shape of src), which is fragile: an item may legitimately have opener=None with an ordinary string source.

Add an explicit to_sync bool on PushItem (default False) and set it to True on the RPM items produced by KonfluxSource, whose content lives in a remote Pulp referenced by src. Consumers should rely on this flag.

Baseline cases are regenerated to include the new field.

@crungehottman

Copy link
Copy Markdown
Member Author

CI is failing on Error: Version 3.9 with arch x64 not found because the latest ubuntu-latest runner image (from ~2026-10-27) dropped Python 3.9 from its tool cache. Fix can be found in #725

@crungehottman
crungehottman force-pushed the konflux-to-sync-attribute branch from 4f29615 to 47de8a5 Compare November 4, 2026 14:27
Consumers (e.g. pubtools-pulp) need to know which items must be synced
into the target system from a remote source rather than uploaded from
local content. Until now this was inferred from the absence of an opener
(or the shape of src), which is fragile: an item may legitimately have
opener=None with an ordinary string source.

Add an explicit to_sync bool on PushItem (default False) and set it to
True on the RPM items produced by KonfluxSource, whose content lives in a
remote Pulp referenced by src. Consumers should rely on this flag.

Baseline cases are regenerated to include the new field.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@crungehottman
crungehottman force-pushed the konflux-to-sync-attribute branch from 47de8a5 to 9531f62 Compare November 4, 2026 14:41
@crungehottman
crungehottman merged commit a013702 into release-engineering:master Nov 4, 2026
6 checks passed
@codecov

codecov Bot commented Nov 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (2ee6ccd) to head (9531f62).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #724   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           59        59           
  Lines         2875      2877    +2     
=========================================
+ Hits          2875      2877    +2     
Flag Coverage Δ
unit-tests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants