Skip to content

Fixing test_handle_containerized_fbc_operation_request_with_overwrite - #1348

Merged
yashvardhannanavati merged 1 commit into
release-engineering:mainfrom
lipoja:test_fix
Jun 17, 2026
Merged

yashvardhannanavati merged 1 commit into
release-engineering:mainfrom
lipoja:test_fix

Conversation

@lipoja

@lipoja lipoja commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

No description provided.

Signed-off-by: Jan Lipovsky <jlipovsk@redhat.com>
@lipoja
lipoja changed the base branch from master to main June 17, 2026 16:21
@fullsend-ai-review

fullsend-ai-review Bot commented Jun 17, 2026 •

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 4:23 PM UTC · Completed 4:30 PM UTC
Commit: 45f7743 · View workflow run →

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Low

  • [scope-clarity] tests/test_workers/test_tasks/test_build_containerized_fbc_operations.py — The change updates test fixtures from short-form image references (fbc:1, index:1) to fully-qualified registry paths (quay.io/iib/fbc-fragment1:latest, quay.io/iib/from-index:latest). This aligns the test data with the convention already established in the sibling test file test_build_fbc_operations.py. A brief PR description noting this is a test data alignment would be helpful but is not blocking.

Info

  • [test-data-convention] tests/test_workers/test_tasks/test_build_containerized_fbc_operations.py — The change aligns with existing test patterns in the codebase. In test_build_fbc_operations.py, the test for overwrite scenarios uses fully-qualified quay.io/iib/* references. Using fully-qualified references is architecturally consistent with similar tests.

@yashvardhannanavati
yashvardhannanavati merged commit 0e65995 into release-engineering:main Jun 17, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants