You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
Update root README test-coverage table after per-step resource change #41
PR #40 moved computeResources from the shared stepTemplate to individual steps, updated tests accordingly (TestStepTemplate now verifies computeResources is absent; two new tests validate per-step resources), and updated the task-level README. However, the root README.md test-coverage table was not updated. The fullsend review agent (run 41476451364) correctly flagged this as a [medium] stale-doc at line 162 and a [low] incomplete-doc at line 163. Two human reviewers approved and the PR was merged at 16:49 UTC without addressing these findings.
What could go better
The root README.md test-coverage table at line 162 now says TestStepTemplate covers "Memory limit, CPU request" but the test class actually verifies that computeResources is absent from stepTemplate (via test_step_template_does_not_share_compute_resources), along with env vars and volume mounts. Line 163's TestTaskSteps description omits the two new per-step compute-resource tests (test_use_trusted_artifact_has_lightweight_compute_resources, test_build_multi_arch_retains_build_compute_resources). This is a straightforward documentation bug — high confidence, confirmed by reading both the merged test file and the README. The review agent caught it correctly; the finding was not addressed before merge.
Proposed change
In README.md, update line 162 to replace "Memory limit, CPU request" with a description reflecting the current test behavior (e.g., "No shared computeResources in stepTemplate"). Update line 163's TestTaskSteps description to include per-step compute-resource validation for use-trusted-artifact (lightweight: 250m CPU, 512Mi/2Gi memory) and build-multi-arch (build: 1 CPU, 4Gi/15Gi memory).
Validation criteria
After the fix, the TestStepTemplate and TestTaskSteps rows in the root README.md test-coverage table accurately describe what the corresponding test classes actually verify, matching the test method names and assertions in tests/tekton/test_iib_image_builder_task.py.
Related issues checked
Searched: README stale test documentation table; computeResources stepTemplate documentation outdated
No overlapping issues found.
Confirmed the documentation drift by reading both the current README.md and tests/tekton/test_iib_image_builder_task.py. Two rows need updating:
TestStepTemplate row (line 162): currently says "Memory limit, CPU request" — should describe the test_step_template_does_not_share_compute_resources assertion (verifies computeResources is absent from stepTemplate)
TestTaskSteps row (line 163): missing the two new test methods test_use_trusted_artifact_has_lightweight_compute_resources and test_build_multi_arch_retains_build_compute_resources
# Proposed test-case (manual validation):# After the fix, verify that:# 1. TestStepTemplate row no longer mentions "Memory limit, CPU request"# and instead reflects absence of computeResources in stepTemplate# 2. TestTaskSteps row mentions per-step compute-resource validation# for both use-trusted-artifact (250m/512Mi/2Gi) and# build-multi-arch (1/4Gi/15Gi)
Labels: Documentation update issue matching the pattern of issue #38; good first issue since it is a small, self-contained text change.
Next steps:
/fs-code — agent creates a PR to implement this issue
/fs-code <your instruction> — agent implements with your specific guidance
Activity
fullsend-ai-triage commentedon Nov 2, 2026
🤖 Finished Triage · ✅ Success · Started 5:04 PM UTC · Completed 5:07 PM UTC
Commit:
300e74d· View workflow run →Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $0.58
fullsend-ai-triage commentedon Nov 2, 2026
Confirmed the documentation drift by reading both the current
README.mdandtests/tekton/test_iib_image_builder_task.py. Two rows need updating:TestStepTemplaterow (line 162): currently says "Memory limit, CPU request" — should describe thetest_step_template_does_not_share_compute_resourcesassertion (verifiescomputeResourcesis absent fromstepTemplate)TestTaskStepsrow (line 163): missing the two new test methodstest_use_trusted_artifact_has_lightweight_compute_resourcesandtest_build_multi_arch_retains_build_compute_resourcesLabels: Documentation update issue matching the pattern of issue #38; good first issue since it is a small, self-contained text change.
Next steps:
/fs-code— agent creates a PR to implement this issue/fs-code <your instruction>— agent implements with your specific guidancefullsend-ai-coder commentedon Nov 2, 2026
🤖 Finished Code · ✅ Success · Started 5:09 PM UTC · Completed 5:13 PM UTC
Commit:
300e74d· View workflow run →Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $1.14