Skip to content

Switch ldap-server to ubi9/python-312 - #99

Merged
guillermodotn merged 1 commit into
mainfrom
overseer/95
Jul 9, 2026
Merged

guillermodotn merged 1 commit into
mainfrom
overseer/95

Conversation

@lubomir

@lubomir lubomir commented Jul 3, 2026 •

Copy link
Copy Markdown
Contributor

Replace the fedora-minimal base image with ubi9/python-312.

The Fedora image is problematic as Renovate is trying to update it to pre-release/rawhide version.

@codecov-commenter

codecov-commenter commented Jul 3, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.65%. Comparing base (e711596) to head (04fc2f4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #99   +/-   ##
=======================================
  Coverage   83.65%   83.65%           
=======================================
  Files          13       13           
  Lines        1328     1328           
=======================================
  Hits         1111     1111           
  Misses        217      217           
Flag Coverage Δ
unit-tests 83.65% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@guillermodotn guillermodotn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the hermetic build + hashed requirements.txt worth the overhead for a test-only LDAP fixture? If we do want the full Konflux treatment, what about registry.access.redhat.com/ubi9/python-312 instead of Docker Hub’s python:3.12-slim.

@lubomir

lubomir commented Jul 9, 2026

Copy link
Copy Markdown
Contributor Author

Yeah, to be fair I don't see this as particularly useful. There's a lot of overhead. I'm not a big fan of pip-compile. Switching to uv would be much nicer, but hermeto doesn't support that.
Switching the base image is a good point.

Replace the fedora-minimal base image with ubi9/python-312.

Generated-By: OpenCode (anthropic/claude-sonnet-4-6)
@lubomir lubomir changed the title Switch ldap-server build to hermetic mode Switch ldap-server to ubi9/python-312 Jul 9, 2026
@guillermodotn
guillermodotn merged commit 55ff8b3 into main Jul 9, 2026
9 checks passed
@lubomir
lubomir deleted the overseer/95 branch July 9, 2026 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants